Avoid unused parameters

Docs > Plateforme de sécurité Datadog > Code Security > Static Code Analysis (SAST) > Règles SAST > Avoid unused parameters

Cette page n'est pas encore disponible en français, sa traduction est en cours.
Si vous avez des questions ou des retours sur notre projet de traduction actuel, n'hésitez pas à nous contacter.

Metadata

ID: apex-code-style/unused-parameters

Language: Apex

Severity: Notice

Category: Best Practices

Description

This rule identifies method parameters that are declared but never used within the method body. Unused parameters can lead to confusion, as they suggest that a value is expected or utilized when it is not, reducing code clarity and maintainability.

To comply with this rule, ensure that every parameter declared in a method signature is actively used within the method. If a parameter is unnecessary, remove it from the method signature. For example, instead of having public static List<Account> getActiveAccounts(Integer limitSize) where limitSize is unused, either use it appropriately in your query or eliminate it entirely.

Non-Compliant Code Examples

public with sharing class AccountHelper {
    public static Integer limitSize = 2;    
    // A method inside the class
    public static List<Account> getActiveAccounts(Integer limitSize) {
        this.limitSize = 5;
    }
}

public with sharing class AccountHelper {
    
    // A method inside the class
    public static List<Account> getActiveAccounts(Integer limitSize) {
        // Query Accounts where Active__c (a custom checkbox field) is true
        List<Account> activeAccounts = [
            SELECT Id, Name, Industry
            FROM Account
            WHERE Active__c = true
            ORDER BY Name
        ];
        
        return activeAccounts;
    }
}

Compliant Code Examples

public with sharing class AccountHelper {
    
    // A method inside the class
    public static List<Account> getActiveAccounts(Integer limitSize) {
        // Query Accounts where Active__c (a custom checkbox field) is true
        List<Account> activeAccounts = [
            SELECT Id, Name, Industry
            FROM Account
            WHERE Active__c = true
            ORDER BY Name
            LIMIT :limitSize
        ];
        
        return activeAccounts;
    }
}