Avoid potential SSRF attacks in your Python code

This page is not yet available in Spanish. We are working on its translation.
If you have any questions or feedback about our current translation project, feel free to reach out to us!

Metadata

ID: python-flask/avoid-ssrf

Language: Python

Severity: Error

Category: Security

CWE: 918

Description

This rule helps prevent Server-Side Request Forgery (SSRF) attacks. SSRF attacks manipulate the server to make HTTP requests to an arbitrary domain of the attacker’s choosing. This can lead to unauthorized actions or access to data within the server, potentially exposing sensitive information.

This rule is important to enforce because SSRF attacks can cause significant damage, allowing attackers to bypass firewall protections, perform actions on behalf of the server, or gain unauthorized access to data. The impact of such an attack can be severe, leading to data breaches or server control takeover.

Good coding practices to avoid SSRF attacks include validating and sanitizing user inputs and limiting the server’s ability to initiate outbound requests.

Learn More

Non-Compliant Code Examples

@app.route("/cmd", methods=['POST'])
def cmd():
    filename = request.form['filename']
    try:
        if "http" not in str(urlparse(filename).scheme):
            host = request.url[:-4]
            filename = host+"/static/" + filename
            result = eval(requests.get(filename).text)
            return render_template("index.html", result=result)
        else:
            result = eval(requests.get(filename).text)
            return render_template("index.html", result=result)
    except Exception:
        return render_template("index.html", result="Unexpected error during the execution of the predefined command.")

Compliant Code Examples

import requests
from flask import request, render_template
from urllib.parse import urlparse

@app.route("/cmd", methods=['POST'])
def cmd():
    filename = request.form.get('filename')
    
    try:
        if not filename or len(filename) > 255:
            raise ValueError("Invalid filename")

        if any(c in filename for c in [';', '&', '|', '$', '<', '>', '`']):
            raise ValueError("Invalid filename")

        parsed_url = urlparse(filename)
        if parsed_url.scheme not in ["http", "https"]:
            host = request.url_root.rstrip('/')
            filename = f"{host}/static/{filename}"

        response = requests.get(filename)
        response.raise_for_status()
        result = response.text
        
        return render_template("index.html", result=result)
    except Exception as e:
        return render_template("index.html", result="Unexpected error during the execution of the predefined command.")