when an if condition returns an value, else is not necessary

Metadata

ID: python-best-practices/if-return-no-else

Language: Python

Severity: Notice

Category: Best Practices

Description

If the code in the if branch returns a value, do not have the else branch present.

Non-Compliant Code Examples

if bla:
    foo()
    return 1
else:  # unnecessary, remove the else branch
    return 2

Compliant Code Examples

if bla:
    foo()
    return 1
elif bar:
    return 2
if bla:
    foo()
    return 1
return 2
if bla:
    foo()
else:
    return 2
https://static.datadoghq.com/static/images/logos/github_avatar.svg https://static.datadoghq.com/static/images/logos/vscode_avatar.svg jetbrains

Seamless integrations. Try Datadog Code Security