Metadata

ID: rust-code-quality/almost-complete-range

Language: Rust

Severity: Error

Category: Error Prone

CWE: 193

Description

A range like 'a'..'z' excludes the last character and is almost certainly a typo for the inclusive range 'a'..='z'. The same applies to 'A'..'Z' and '0'..'9', as well as their byte literal equivalents (b'a'..b'z', etc.)

Non-Compliant Code Examples

fn is_lowercase(c: char) -> bool {
  ('a'..'z').contains(&c)
}

fn is_digit_byte(b: u8) -> bool {
  (b'0'..b'9').contains(&b)
}

Compliant Code Examples

fn is_lowercase(c: char) -> bool {
  ('a'..='z').contains(&c)  
}

fn is_digit_byte(b: u8) -> bool {
  (b'0'..='9').contains(&b) 
}

fn beginning_to_f(c: char) -> bool {
  ('a'..'f').contains(&c)
}  

Seamless integrations. Try Datadog Code Security

Datadog Code Security