Use Contains for simple equality

Docs > Datadog Security > Code Security > Static Code Analysis (SAST) > SAST Rules > Use Contains for simple equality

Metadata

ID: csharp-best-practices/contains-not-any

Language: C#

Severity: Warning

Category: Best Practices

Description

When using only a simple comparison, use Contains instead of Any as it is more efficient in terms of resources allocation.

Non-Compliant Code Examples

using System.Xml;

class MyClass {
    public static bool filter(IEnumerable<int> values, int target)
    {
        return values.Any(x => target == x);
    }
}

using System.Xml;

class MyClass {
    public static bool filter(IEnumerable<int> values, int target)
    {
        return values.Any(x => x == target);
    }
}

Compliant Code Examples

using System.Xml;

class MyClass {
    public static bool filter1(IEnumerable<int> values, int target)
    {
        return values.Contains(target);
    }
    public static bool filter2(IEnumerable<int> values, int target)
    {
        return values.Any(c => c > target);
    }
    public static bool filter3(IEnumerable<SomeType> values, int target)
    {
        return values.Any(c => c.Id == target);
    }
}