Do not defer Lock

Docs > Datadog Security > Code Security > Static Code Analysis (SAST) > SAST ルール > Do not defer Lock

このページは日本語には対応しておりません。随時翻訳に取り組んでいます。
翻訳に関してご質問やご意見ございましたら、お気軽にご連絡ください。

Metadata

ID: go-best-practices/defer-lock

Language: Go

Severity: Info

Category: Best Practices

Description

Deferring calls to Mutex.Lock() is nearly always a mistake, either by introducing a defer where it doesn’t belong, or by mistyping Unlock as Lock.

Non-Compliant Code Examples

func test() {
    mutex.Lock()
    defer mutex.Lock()
}

func test() {
    defer mutex.Lock()
}

func test() {
    mutex.RLock()
    defer mutex.RLock()
}

func test() {
    defer mutex.RLock()
}

Compliant Code Examples

func test() {
    mutex.Lock()
    defer mutex.Unlock()
}

func test() {
    mutex.RLock()
    defer mutex.RUnlock()
}