when an if condition returns an value, else is not necessary

Documentos > Code Analysis > Static Analysis Rules > when an if condition returns an value, else is not necessary

This page is not yet available in Spanish. We are working on its translation.
If you have any questions or feedback about our current translation project, feel free to reach out to us!

Metadata

ID: python-best-practices/if-return-no-else

Language: Python

Severity: Notice

Category: Best Practices

Description

If the code in the if branch returns a value, do not have the else branch present.

Non-Compliant Code Examples

if bla:
	foo()
	return 1
else:  # unnecessary, remove the else branch
	return 2

Compliant Code Examples

if bla:
	foo()
	return 1
elif bar:
	return 2

if bla:
	foo()
	return 1
return 2

if bla:
	foo()
else:
	return 2

How to use this rule

1
2
rulesets:
  - python-best-practices     # Rules to enforce Python best practices.

Create a static-analysis.datadog.yml with the content above at the root of your repository
Use our free IDE Plugins or add Code Analysis scans to your CI pipelines
Get feedback on your code

For more information, please read the Code Analysis documentation

VS Code Extension

Identify code vulnerabilities directly in your
VS Code editor

JetBrains Plugin

Identify code vulnerabilities directly in
JetBrains products