Avoid empty critical sections

Docs > Code Analysis > Static Analysis Rules > Avoid empty critical sections

This page is not yet available in Spanish. We are working on its translation.
If you have any questions or feedback about our current translation project, feel free to reach out to us!

Metadata

ID: go-best-practices/avoid-empty-critical-sections

Language: Go

Severity: Info

Category: Best Practices

Description

Empty critical sections are often a mistake. Instead of unlocking, developers often miss using defer to defer unlocking the mutex.

Non-Compliant Code Examples

func test() {
    mutex.Lock()
    mutex.Unlock()
}

Compliant Code Examples

func test() {
    mutex.Lock()
    doSomething()
    mutex.Unlock()
}

How to use this rule

1
2
rulesets:
  - go-best-practices     # Rules to enforce Go best practices.

Create a static-analysis.datadog.yml with the content above at the root of your repository
Use our free IDE Plugins or add Code Analysis scans to your CI pipelines
Get feedback on your code

For more information, please read the Code Analysis documentation

VS Code Extension

Identify code vulnerabilities directly in your
VS Code editor

JetBrains Plugin

Identify code vulnerabilities directly in
JetBrains products