HostnameVerifier should check certificates

Metadata

ID: java-security/hostname-verifier-true

Language: Java

Severity: Error

Category: Security

CWE: 295

Description

A HostnameVerifier implementation should never just return true.

Learn More

Non-Compliant Code Examples

public class AllHosts implements HostnameVerifier {
    public boolean verify(final String hostname, final SSLSession session) {
        return true;
    }
}

Compliant Code Examples

public class AllHosts implements HostnameVerifier {
    public boolean verify(final String hostname, final SSLSession session) {
        if(isValidCertificate) {
            return true;
        }
        return false;
    }
}
https://static.datadoghq.com/static/images/logos/github_avatar.svg https://static.datadoghq.com/static/images/logos/vscode_avatar.svg jetbrains

Seamless integrations. Try Datadog Code Analysis