API

Use Contains for simple equality

Docs > Code Analysis > Static Analysis Rules > Use Contains for simple equality

Metadata

ID: csharp-best-practices/contains-not-any

Language: C#

Severity: Warning

Category: Best Practices

Description

When using only a simple comparison, use Contains instead of Any as it is more efficient in terms of resources allocation.

Non-Compliant Code Examples

using System.Xml;

class MyClass {
    public static bool filter(IEnumerable<int> values, int target)
    {
        return values.Any(x => x > target);
        return values.Any(x => x == target);
    }
}

Compliant Code Examples

using System.Xml;

class MyClass {
    public static bool filter(IEnumerable<int> values, int target)
    {
        if (values.Any(c => c == Enum.Member)) {
            return values.Contains(target);
        }
    }
}

How to use this rule

1
2
rulesets:
  - csharp-best-practices     # Rules to enforce C# best practices.

Create a static-analysis.datadog.yml with the content above at the root of your repository
Use our free IDE Plugins or add Code Analysis scans to your CI pipelines
Get feedback on your code

For more information, please read the Code Analysis documentation

VS Code Extension

Identify code vulnerabilities directly in your
VS Code editor

JetBrains Plugin

Identify code vulnerabilities directly in
JetBrains products